Skip to content

COMP: Build against ITK main; sync ExternalData config; fix docs env#456

Open
hjmjohnson wants to merge 3 commits into
InsightSoftwareConsortium:mainfrom
hjmjohnson:fix/ci-itk-pin-and-deps
Open

COMP: Build against ITK main; sync ExternalData config; fix docs env#456
hjmjohnson wants to merge 3 commits into
InsightSoftwareConsortium:mainfrom
hjmjohnson:fix/ci-itk-pin-and-deps

Conversation

@hjmjohnson

Copy link
Copy Markdown
Member

Build against ITK main, sync the ExternalData configuration with ITK upstream, fix the docs notebook env (zarr>=3), and finish the repo's sha512→cid conversion. With ITKTestingData#63/#64 merged, this addresses the remaining CI-infrastructure failures on every open PR. Blocked on ITKTestingData#65 (CID copies of the FFT blobs).

What each change fixes
Change Failure it fixes
Superbuild ITK_TAG v5.4.2 → main (matches the C++ jobs' itk-git-tag) Python baseline-comparison failures (ThinPlateSpline/Resample/InverseFFT/RGB→Gray) — cxx jobs on ITK main pass where the v5.4.2 superbuild fails
pip itk>=5.4.2/>=5.4rc3>=5.4.6 stale wheels in superbuild venv and notebooks job
zarr>=3.0.0 in the superbuild venv build_html hard failure: nbsphinx executing ConvertNumPyArrayToitkImage.ipynb hits ValueError: zarr-python >= 3.0.0b2 required for OME-Zarr >= 0.5
ITKSphinxExamplesExternalData.cmake + ExternalData.cmake synced to ITK main adds Girder hashsum, filebase, and pinata-public mirrors; drops dead estuary.tech/w3s.link and the released-root-CID gateways; WASI symlink guard. Project-specific gin.g-node.org mirror and ExternalData_LINK_CONTENT=CID retained
ComputeFFTInOneDimension .sha512.cid (last 6 hash links repo-wide) FFT fetch failures (MouseLiverRF.mha does not exist); blobs published in ITKTestingData#64 (SHA512) and #65 (CID)

Superbuild ITK_TAG v5.4.2 -> main, matching the C++ CI jobs and
picking up post-5.4.2 fixes behind the Python baseline mismatches.
pip itk pins -> >=5.4.6; zarr>=3.0.0 satisfies ngff-zarr OME-Zarr 0.5
(nbsphinx notebook execution failed without it).

ExternalData URL templates and module now mirror ITK main: adds the
Girder hashsum mirror (sole host of some legacy sha512 objects, e.g.
ComputeFFTInOneDimension), filebase and pinata public gateways, and
the WASI symlink guard; drops dead estuary.tech/w3s.link and the
released-root-CID gateways. The project-specific gin.g-node.org
mirror and ExternalData_LINK_CONTENT=CID are retained.
Last remaining hash-based links in the repository; blobs published
under CID in ITKTestingData#64.
@github-actions github-actions Bot added area:Filtering Issues affecting the Filtering module type:Compiler Compiler support or related warnings type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Data Changes to example data (usually displayed images) labels Jun 11, 2026
@hjmjohnson hjmjohnson marked this pull request as ready for review June 11, 2026 01:08
@hjmjohnson

Copy link
Copy Markdown
Member Author

Finding from #455's re-run: the sha512→cid conversion here is required, not cosmetic — the top-level CMakeLists.txt data-staging glob matches *.cid only, so the 6 .sha512 content links were never staged into the binary tree (MouseLiverRF.mha does not exist), and the baseline-comparison macro's string(REPLACE .cid "") likewise passes literal .mha.sha512 paths as baselines. The FFT tests have been structurally unable to run since those links were added.

@hjmjohnson

Copy link
Copy Markdown
Member Author

Folded the visual-cid fix from #455 (closed) into this PR as f759c48 — with ITKTestingData#63/#64/#65 all merged, every content link this PR's CI needs is now published. Remaining known blocker: the ITKReview/zlib link regression on ITK main hits the superbuild jobs (fix validated locally; ITK PR pending).

@github-actions github-actions Bot added area:Core Issues affecting the Core module area:Documentation Issues affecting the Documentation module labels Jun 11, 2026
The 20 PNGs referenced since InsightSoftwareConsortium#440 were never published to
ITKTestingData and are unrecoverable from any public source; every
build of Module_SphinxExamples fails 20 ExternalData fetches. Point
the .cid files at recreated diagrams (ITKTestingData#63) and fix the
Operator.png/Operation.png reference mismatch.
@hjmjohnson hjmjohnson force-pushed the fix/ci-itk-pin-and-deps branch from f759c48 to d2521d3 Compare June 11, 2026 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Core Issues affecting the Core module area:Documentation Issues affecting the Documentation module area:Filtering Issues affecting the Filtering module type:Compiler Compiler support or related warnings type:Data Changes to example data (usually displayed images) type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant